Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLIng diet #1897

Merged
merged 17 commits into from
Nov 13, 2024
Merged

CLIng diet #1897

merged 17 commits into from
Nov 13, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 11, 2024

First part was to "reverse" MavenCli into CLIng, that also became a huge and complex beast. Now, sanitization comes, tearing down unneeded stuff. CLIng should be simple and straightforward.

Now the invoker fully parses args, creates Maven instance (ie. local, using Maven components on classpath) and invokes Maven. The new executor in turn does NOT fully parses args and is logical equivalent of maven-invoker.

Changes:

  • radically simplify CLIng existing classes (and especially API - the fact we have "local", "resident" etc invoker is actually implementation detail).
  • introduce "executor", a "lower level" tool that does not parse args (and is logical equivalent of maven-invoker) and support Maven 4.x and Maven 3.x.

First part was to "reverse" MavenCli into CLIng, that
also became a huge and complex beast. Now, sanitization
comes, tearing down unneeded stuff.

WIP
@cstamas cstamas added this to the 4.0.0-beta-6 milestone Nov 11, 2024
@cstamas cstamas requested a review from gnodet November 11, 2024 15:14
@cstamas cstamas self-assigned this Nov 11, 2024
@cstamas cstamas marked this pull request as ready for review November 12, 2024 16:53
@gnodet
Copy link
Contributor

gnodet commented Nov 13, 2024

Have you tried with mvnd yet ?

We get recently a flood of GOAWAY messages, that JDK HttpClient
cannot cope with in reasonable way.
Executor does not have exit exception
@cstamas cstamas merged commit a67d274 into apache:master Nov 13, 2024
13 checks passed
@cstamas cstamas deleted the cling-diet branch November 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants